Al Viro sez: > > > +#define LE32_ALL_ONES ((__force __le32)0xffffffff) > > I don't like having this in an actual driver. It might make sense to > > either have this in a common header or actually allowing to assign all > > ones to __l32*/__be* variables. Al? > It doesn't make sense, period. Use cpu_to_le32(~0U) - calculations will > be done at compile time and it's self-documenting. Definition above > is not more efficient or easier to type, so... As long as this is guaranteed on all platforms to do the right thing ... paranoid about compiler optimizations. MarkH, this should be an easy regroup :-) Sincerely -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html