Re: [PATCH] aacraid 2.6: Address sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +			u32 temp = le32_to_cpu(psg->sg[i-1].count) - 
> +				(byte_count - scsicmd->request_bufflen);
> +			psg->sg[i-1].count = cpu_to_le32(temp);

You really want {be,le}*_{add,sub} helpers.  I needed them on various
occasions, too.  Al, what do you think about adding these helpers to a
common header somewhere?

> +#define LE32_ALL_ONES ((__force __le32)0xffffffff)

I don't like having this in an actual driver.  It might make sense to
either have this in a common header or actually allowing to assign all
ones to __l32*/__be* variables.  Al?

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux