On Wed, Mar 30, 2005 at 08:07:02PM +0200, Kay Sievers wrote: > On Tue, Mar 29, 2005 at 08:20:43PM -0800, Greg KH wrote: > > On Wed, Mar 30, 2005 at 05:15:55AM +0200, Kay Sievers wrote: > > > /** > > > + * sysfs_chmod_file - update the modified mode value on an object attribute. > > > + * @kobj: object we're acting for. > > > + * @mode: file permissions. > > > + * > > > + */ > > > +int sysfs_chmod_file(struct kobject *kobj, const struct attribute *attr) > > > > Your documentation doesn't match up with your function arguments :) > > Bah, I tried both versions. :) > > > Shouldn't you want an extra mode variable? Makes it easier to override > > than remembering to change the mode in the attribute before calling the > > function. > > If that's better, sure. Here is a new patch. Looks good, applied to my tree. thanks, greg k-h - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
