On 17.12.2020 11:14, Stephen Boyd wrote: > Not sure why this wasn't picked up in the samsung PR. Can you resend? Hi There was v2 (https://patchwork.kernel.org/project/linux-samsung-soc/patch/20201107121456.25562-1-pawel.mikolaj.chmiel@xxxxxxxxx/) but it did receive some request for changes comments and i didn't yet had time to it. > >> diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c >> index c1ff715e960c..1048d83f097b 100644 >> --- a/drivers/clk/samsung/clk-exynos7.c >> +++ b/drivers/clk/samsung/clk-exynos7.c >> @@ -538,7 +538,8 @@ static const struct samsung_gate_clock top1_gate_clks[] __initconst = { >> ENABLE_ACLK_TOP13, 28, CLK_SET_RATE_PARENT | >> CLK_IS_CRITICAL, 0), >> GATE(CLK_ACLK_FSYS1_200, "aclk_fsys1_200", "dout_aclk_fsys1_200", >> - ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT, 0), >> + ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT | >> + CLK_IS_CRITICAL, 0), >> > > Please put a comment in the code why a clk is critica>