Hi Simon,
On 4/19/2018 8:31 PM, Simon Shields wrote:
> Hi all,
>
> On 10/04/2018 10:21 PM, Grigor Tovmasyan wrote:
>> Here are two little fixes for LPM feature.
>>
>> First one is coverity warning fix.
>>
>> The Second one was asserted by Stefan Wahren.
>>
>> Changes from version 0:
>>
>> 1/2:
>> - Instead of converting parameter in the CHECK_RANGE macro
>> to int, changed hird_threshold type from u8 to int.
>>
>>
>> Grigor Tovmasyan (2):
>> usb: dwc2: gadget: Fix coverity issue
>> usb: dwc2: gadget: Change LPM default values
>>
>> drivers/usb/dwc2/core.h | 2 +-
>> drivers/usb/dwc2/params.c | 8 ++++----
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> The second patch in this series fixes a regression in 4.17-rc1 using dwc2 in gadget
> mode on Exynos4412, introduced by commit 7455f8b7f0b3 ("usb: dwc2: Enable
> LPM"). The regression is that using the cdc_acm serial gadget (and
> presumably other gadgets) serial console output will only sporadically
> show up on the host (it seems to only show up as input is sent).
>
The second patch is not fix for described by you issue. We will try to
reproduce your issue and provide fix. Could you provide some logs or usb
traces for issue?
> However, I'm unsure if completely disabling LPM is the correct fix, as the dwc2
> revision in Exynos4412 (0x4f54281a) should support LPM according to the
> source
Yes, we can enable LPM based on hardware configuration.
> I'm not really sure how to debug this any further (vendor kernel
> releases contain no mention of LPM in the gadget drivers), so any pointers
> in that direction would be much appreciated.
>
> Cheers,
> Simon
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
