On Tue, Apr 17, 2018 at 12:02 PM, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > Hi Andi, > > On 04/16/2018 09:09 PM, andi@xxxxxxxxxxx wrote: >> On 17.04.2018 00:40, Sylwester Nawrocki wrote: >>> The spi pointer argument is not used now so remove it. While at it >>> s3c64xx_ prefix is added to the function name. >> >> These for me are two different patches, but in any case it's trivial >> so that I don't mind it too much. > > I am going to drop renaming from this patch. There are 2 more functions > (wait_for_pio(), wait_for_dma()) without prefix, should we rename them > too or rather leave all 3 as they are now? Indeed it is kind of mixed up - some purely local functions (not even passed through pointer to some ops) have prefix, some do not. If you ask me, I would prefer to have the prefix on all of them because: 1. If they appear in call trace (where backtrace pointers are not telling anything) it is easy to understand their location, 2. having generic name like "wait_for_dma" sounds for me like generic, Linux-wide macro (but it is not). However I do not insist on that. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |