On Tue, Mar 27, 2018 at 3:58 PM, Chanho Park <parkch98@xxxxxxxxx> wrote: > This patch adds a samsung_pin_dbg_show function to implement the > pin_dbg_show callback function which can be used to show pin > confuration values. Basically, it can show pin setting values by > accessing the "pins" node like below: > > $ cat pins > pin 0 (gpy7-0) CON(0x0) DAT(0x1) PUD(0x1) DRV(0x0) CON_PDN(0x0) PUD_PDN(0x0) > > Signed-off-by: Chanho Park <parkch98@xxxxxxxxx> > --- > Changes from v1: > - use samsung_pinconf_get instead of samsung_pinconf_rw > - use "static const char * const" type declaration of reg_names > - skip condition change > > drivers/pinctrl/samsung/pinctrl-samsung.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Looks fine, thanks: Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Linus, I do not have anything in my pinctrl queue for you so maybe you can take it directly? Otherwise, I will apply it after upcoming merge window. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html