On 03/19/2018 03:29 PM, Sylwester Nawrocki wrote:
> Valid range for those controls is specified in documentation as [0, 51],
> so initialize the controls to such range rather than [INT_MIN, INT_MAX].
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
Huh, I missed this when I reviewed this earlier. Thanks for catching this!
Regards,
Hans
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index 810dabe2f1b9..7382b41f4f6d 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -856,56 +856,56 @@ static struct mfc_control controls[] = {
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
