Hi Marek,
On 2018년 03월 13일 18:39, Marek Szyprowski wrote:
> FIMC LITE SYSMMU device are defined in exynos5250.dtsi, but clocks for
> them are not instantiated by Exynos5250 clock provider driver. Add
> needed definitions for those clocks to fix IOMMU probe failure:
>
> ERROR: could not get clock /soc/sysmmu@13c40000:sysmmu(0)
> exynos-sysmmu 13c40000.sysmmu: Failed to get device clock(s)!
> exynos-sysmmu: probe of 13c40000.sysmmu failed with error -38
> ERROR: could not get clock /soc/sysmmu@13c50000:sysmmu(0)
> exynos-sysmmu 13c50000.sysmmu: Failed to get device clock(s)!
> exynos-sysmmu: probe of 13c50000.sysmmu failed with error -38
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> drivers/clk/samsung/clk-exynos5250.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
> index 06e5ddcb30db..347fd80c351b 100644
> --- a/drivers/clk/samsung/clk-exynos5250.c
> +++ b/drivers/clk/samsung/clk-exynos5250.c
> @@ -561,6 +561,8 @@ static const struct samsung_gate_clock exynos5250_gate_clks[] __initconst = {
> 0),
> GATE(CLK_GSCL3, "gscl3", "mout_aclk266_gscl_sub", GATE_IP_GSCL, 3, 0,
> 0),
> + GATE(CLK_CAMIF_TOP, "camif_top", "mout_aclk266_gscl_sub",
> + GATE_IP_GSCL, 4, 0, 0),
> GATE(CLK_GSCL_WA, "gscl_wa", "div_gscl_wa", GATE_IP_GSCL, 5, 0, 0),
> GATE(CLK_GSCL_WB, "gscl_wb", "div_gscl_wb", GATE_IP_GSCL, 6, 0, 0),
> GATE(CLK_SMMU_GSCL0, "smmu_gscl0", "mout_aclk266_gscl_sub",
> @@ -571,6 +573,10 @@ static const struct samsung_gate_clock exynos5250_gate_clks[] __initconst = {
> GATE_IP_GSCL, 9, 0, 0),
> GATE(CLK_SMMU_GSCL3, "smmu_gscl3", "mout_aclk266_gscl_sub",
> GATE_IP_GSCL, 10, 0, 0),
> + GATE(CLK_SMMU_FIMC_LITE0, "smmu_fimc_lite0", "mout_aclk266_gscl_sub",
> + GATE_IP_GSCL, 11, 0, 0),
> + GATE(CLK_SMMU_FIMC_LITE1, "smmu_fimc_lite1", "mout_aclk266_gscl_sub",
> + GATE_IP_GSCL, 12, 0, 0),
>
>
> GATE(CLK_MFC, "mfc", "mout_aclk333_sub", GATE_IP_MFC, 0, 0, 0),
>
Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
And,
The bfed1074f2130 ("clk: exynos5250: Add missing sysmmu clocks for DISP and ISP blocks")
patch added the following clock id without implementing the real clock to clk-exynos5250.c.
- #define CLK_SMMU_FIMC_LITE0 363
- #define CLK_SMMU_FIMC_LITE1 364
- +#define CLK_CAMIF_TOP 365
How about adding the fixes tag?
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
