Ok, but in that case the original code is still wrong because it returns early with success. I guess it could be changed to: if (irq <= 0) return -ENXIO; regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html