Hi, On 02/22/2018 09:38 AM, Krzysztof Kozlowski wrote: > On Thu, Feb 22, 2018 at 5:19 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: >> I was doing some regular cleanups in the core and had a look at >> samsung drivers for that. I am quite sure I am not reading the code >> correctly, and need your help in that. >> >> The s3c24xx-cpufreq.c driver is used by s3c2410-cpufreq.c, >> s3c2412-cpufreq.c and s3c2440-cpufreq.c files but only the >> last one is actually setting the calc_freqtable() callback. That makes >> me wonder if the cpufreq stuff is working on 2410/2412 at all, or if >> anyone is actually using it there. >> >> If calc_freqtable() callback isn't present, we wouldn't have a frequency >> table (ftab) in the 24xx driver and so ->s3c_cpufreq_init() should just >> fail. >> >> Can you please help me understanding this piece of code ? > Unfortunately I do not have these boards. Few months ago I was trying > to get a development board from one of manufacturers (FriendlyARM) but > they said that all boards are sold out. > > I know that guys in Poland have one working and I think Sylwester > brought it up to live. > > Sylwester, could you help here? The odds are good cpufreq on S3C2410 is indeed broken in current mainline kernel, probably no one is doing test on that platform any more. I wouldn't be surprised if there were regressions since several kernel releases on that platform. Unfortunately, I have only an S3C2440 based Micro2440 ev. board, so I can't test this. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |