Hi, On 2018년 02월 20일 16:05, Andrzej Hajda wrote: > Rates declared in PLL rate tables should match exactly rates calculated > from PLL coefficients. To avoid possible mistakes we can use compile > time validation. > The patch introduces such validators and expands all initializers > with additional input frequency parameter, required to validate rates. > Since S3C24xx PLLs requires different validators two new macros have > been introduced to deal with it. Also since PLLs 4502 and 4508 have > different formulas PLL_45XX_RATE has been replaced with PLL_4508_RATE. > > As the patch adds only compile time validators it should not have impact > on compiled code. > > Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Acked-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> > --- > v3 (addressed Chanwoo comments): > - renamed PLL_45XX_RATE to PLL_4508_rate, > - modified PLL_S3C2440_MPLL_RATE to match exactly code in recalc_rate > > v2: > - replaced custom checker with existing BUILD_BUG_ON_ZERO, > - fixed comment (by annihilation), > - added Acked-By > --- > drivers/clk/samsung/clk-exynos3250.c | 114 +++++++++++++++++----------------- > drivers/clk/samsung/clk-exynos4.c | 102 +++++++++++++++--------------- > drivers/clk/samsung/clk-exynos5250.c | 54 ++++++++-------- > drivers/clk/samsung/clk-exynos5260.c | 90 +++++++++++++-------------- > drivers/clk/samsung/clk-exynos5410.c | 20 +++--- > drivers/clk/samsung/clk-exynos5420.c | 62 +++++++++---------- > drivers/clk/samsung/clk-exynos5433.c | 116 +++++++++++++++++------------------ > drivers/clk/samsung/clk-exynos7.c | 2 +- > drivers/clk/samsung/clk-pll.h | 48 ++++++++++++--- > drivers/clk/samsung/clk-s3c2410.c | 108 ++++++++++++++++---------------- > 10 files changed, 372 insertions(+), 344 deletions(-) > Looks good to me. Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> [snip] -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |