Hi Rob, Thanks for the review. On Wed, Dec 20, 2017 at 12:17:59PM -0600, Rob Herring wrote: > On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote: > > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along > > with the shared "midas" binding. > > > > Signed-off-by: Simon Shields <simon@xxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > My comment on v2 remains. Do you have any example of a better description? All the other ARM board descriptions seem similarly terse. Alternatively, maybe changing the compatible strings is a better solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and "samsung,i9305" for m3? Cheers, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |