Dear Marek, On 2017년 11월 30일 11:21, Chanwoo Choi wrote: > Dear Marek, > > On 2017년 11월 29일 20:26, Marek Szyprowski wrote: >> This patch adds support for MFC power domain to Exynos 5433 SoCs, which >> contains following devices: a clock controller, MFC codec device and its >> SYSMMUs. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 0a06be283a31..cfa2a0d4dc2f 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -486,6 +486,7 @@ > > Looks good to me. > Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > > [snip] > As I commented on patch3, when adding the MFC power domain, you need to add the 'power-domain' property for 'bus_mfc' device-tree node as following: [Adding power-domain to bus device-tree node] diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi index ec11343dc528..0e1a7e01b8ed 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi @@ -55,6 +56,7 @@ clocks = <&cmu_top CLK_ACLK_MFC_400>; clock-names = "bus"; operating-points-v2 = <&bus_g2d_400_opp_table>; + power-domains = <&pd_mfc>; status = "disabled"; }; -- Best Regards, Chanwoo Choi Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html