Hi,
On Tue, Oct 3, 2017 at 7:00 PM, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> S3C2443 platform still use non-dt based lookup in some of its drivers to
> get MPLL and EPLL clocks. Till now it worked only because PLL() macro
> implicitely created aliases for all instatiated clocks. This feature will
> be removed, so explicitely create aliases for MPLL and EPLL clocks.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> drivers/clk/samsung/clk-s3c2443.c | 10 ++++++----
> include/dt-bindings/clock/s3c2443.h | 2 ++
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-s3c2443.c b/drivers/clk/samsung/clk-s3c2443.c
> index 45166033f638..d94b85a42356 100644
> --- a/drivers/clk/samsung/clk-s3c2443.c
> +++ b/drivers/clk/samsung/clk-s3c2443.c
> @@ -191,6 +191,8 @@ struct samsung_gate_clock s3c2443_common_gates[] __initdata = {
> struct samsung_clock_alias s3c2443_common_aliases[] __initdata = {
> ALIAS(MSYSCLK, NULL, "msysclk"),
> ALIAS(ARMCLK, NULL, "armclk"),
> + ALIAS(MPLL, NULL, "mpll"),
> + ALIAS(EPLL, NULL, "epll"),
> ALIAS(HCLK, NULL, "hclk"),
> ALIAS(HCLK_SSMC, NULL, "nand"),
> ALIAS(PCLK_UART0, "s3c2440-uart.0", "uart"),
> @@ -223,9 +225,9 @@ struct samsung_clock_alias s3c2443_common_aliases[] __initdata = {
> /* S3C2416 specific clocks */
>
> static struct samsung_pll_clock s3c2416_pll_clks[] __initdata = {
> - [mpll] = PLL(pll_6552_s3c2416, 0, "mpll", "mpllref",
> + [mpll] = PLL(pll_6552_s3c2416, MPLL, "mpll", "mpllref",
> LOCKCON0, MPLLCON, NULL),
> - [epll] = PLL(pll_6553, 0, "epll", "epllref",
> + [epll] = PLL(pll_6553, EPLL, "epll", "epllref",
> LOCKCON1, EPLLCON, NULL),
> };
>
> @@ -277,9 +279,9 @@ struct samsung_clock_alias s3c2416_aliases[] __initdata = {
> /* S3C2443 specific clocks */
>
> static struct samsung_pll_clock s3c2443_pll_clks[] __initdata = {
> - [mpll] = PLL(pll_3000, 0, "mpll", "mpllref",
> + [mpll] = PLL(pll_3000, MPLL, "mpll", "mpllref",
> LOCKCON0, MPLLCON, NULL),
> - [epll] = PLL(pll_2126, 0, "epll", "epllref",
> + [epll] = PLL(pll_2126, EPLL, "epll", "epllref",
> LOCKCON1, EPLLCON, NULL),
> };
>
> diff --git a/include/dt-bindings/clock/s3c2443.h b/include/dt-bindings/clock/s3c2443.h
> index 37e66b054d64..f3ba68a25ecb 100644
> --- a/include/dt-bindings/clock/s3c2443.h
> +++ b/include/dt-bindings/clock/s3c2443.h
> @@ -26,6 +26,8 @@
> #define ARMCLK 4
> #define HCLK 5
> #define PCLK 6
> +#define MPLL 7
> +#define EPLL 8
>
> /* Special clocks */
> #define SCLK_HSSPI0 16
When using PLL() macro, pll uses the 'name' as for both 'name' and 'alias'.
The patch9 removes the registration of PLL's alias in the
_samsung_clk_register_pll().
So, this patch looks good to me for patch9.
Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
