On Mon, Oct 02, 2017 at 08:59:34AM +0200, Marek Szyprowski wrote: > > > On 2017-10-02 08:44, Krzysztof Kozlowski wrote: > > On Mon, Oct 2, 2017 at 8:34 AM, Marek Szyprowski > > <m.szyprowski@xxxxxxxxxxx> wrote: > > > Hi Krzysztof, > > > > > > On 2017-09-30 19:23, Krzysztof Kozlowski wrote: > > > > On Fri, Sep 29, 2017 at 01:33:02PM +0200, Marek Szyprowski wrote: > > > > > Odroid HC1 board is based on Odroid XU4 board, but it has no HDMI, > > > > > no eMMC, no build-in USB3.0 hub, no extension port pins, and no GPIO > > > > > button. USB3.0 ports are used for build-in JMicron USB to SATA bridge > > > > > and Gigabit R8152 ethernet chips. HC1 uses only passive cooling. > > > > > > > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > > > > --- > > > > > arch/arm/boot/dts/Makefile | 1 + > > > > > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 443 > > > > > +++++++++++++++++++++ > > > > > arch/arm/boot/dts/exynos5422-odroidhc1.dts | 217 ++++++++++ > > > > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 428 > > > > > +------------------- > > > > Please experiment with -M (maybe -M20%?) and -B so this would be > > > > detected as rename. It might create much simpler patch thus making the > > > > review easy (one could see that the changes are just movements). > > > > > > I didn't manage to generate different patch with those options. I have > > > however checked that odroidxu3/xu3-lite/xu4 dtbs are exactly the same after > > > applying this patch (using dtx_diff tool). > > Then it looks like the same issue as here: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/477315.html > > > > You are using some ancient git (v1.9.1) which was released more than > > three years ago. March 2014. As Andi pointed in that thread - he had > > no problems with -M and -B on newer version. > > 3 years old software is not really an ancient software - it a stable version > from LTS distro. Unless you need some newly added features it is imho fine > to > use for your DAILY work. Anyway, I've just checked with git v2.14.2 and it > generates exactly the same diffs. I also experimented (including -C and --find-copies-harder) but indeed git did not want to detect the copy. Anyway thanks for trying and confirming with dtx_diff. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |