On Mon, Aug 28, 2017 at 07:01:02PM +0900, Jaechul Lee wrote:
> devm_gpiod_get is called with GPIOF_OUT_INIT_LOW but the function doesn't
> allow the parameters. Unluckily, GPIOF_OUT_INIT_LOW is same value as
> GPIOD_IN so it works like input gpio.
In overall, makes sense however one thing troubles me:
GPIOF_OUT_INIT_LOW = 0x0
GPIOD_IN = BIT(0) = 0x1
Are you sure they have the same value? Maybe you meant GPIOD_ASIS?
Best regards,
Krzysztof
>
> Muted stream comes up when I try recording some sounds on TM2. mic-bias
> gpiod state can't be changed because the gpiod is created with the invalid
> parameter. The gpio should be set GPIOD_OUT_HIGH.
>
> Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
> Signed-off-by: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
> ---
> sound/soc/samsung/tm2_wm5110.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
> index f467ad06e827..76abe45ed537 100644
> --- a/sound/soc/samsung/tm2_wm5110.c
> +++ b/sound/soc/samsung/tm2_wm5110.c
> @@ -439,8 +439,7 @@ static int tm2_probe(struct platform_device *pdev)
> snd_soc_card_set_drvdata(card, priv);
> card->dev = dev;
>
> - priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias",
> - GPIOF_OUT_INIT_LOW);
> + priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", GPIOD_OUT_HIGH);
> if (IS_ERR(priv->gpio_mic_bias)) {
> dev_err(dev, "Failed to get mic bias gpio\n");
> return PTR_ERR(priv->gpio_mic_bias);
> --
> 2.14.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
