Re: [PATCH] exynos: add C++ support to exynos_drmif header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
> Add the usual extern "C" when compiling in C++ mode.

Thanks, but why specifically this header? The other exynos/*.h headers
also lack the c++ mangling guard.

A quick grep shows that only 15/101 headers in libdrm have it.
Can I interest you in fixing a few more headers? :)

In any case, this patch is:
Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
(I assume you'll push it yourself?)

Btw, can you run this in your local libdrm repo?
  $ git config --local format.subjectPrefix "PATCH libdrm"

Cheers,
  Eric


> 
> Signed-off-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  exynos/exynos_drmif.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
> index 626e399..154439b 100644
> --- a/exynos/exynos_drmif.h
> +++ b/exynos/exynos_drmif.h
> @@ -31,6 +31,10 @@
>  #include <stdint.h>
>  #include "exynos_drm.h"
>  
> +#if defined(__cplusplus)
> +extern "C" {
> +#endif
> +
>  struct exynos_device {
>  	int fd;
>  };
> @@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
>  				struct exynos_event_context *ctx);
>  
>  
> +#if defined(__cplusplus)
> +}
> +#endif
> +
>  #endif /* EXYNOS_DRMIF_H_ */
> -- 
> 2.7.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux