On Friday 31 March 2017 01:39 PM, Arnd Bergmann wrote: > On Fri, Mar 31, 2017 at 7:36 AM, pankaj.dubey <pankaj.dubey@xxxxxxxxxxx> wrote: >> Hi Arnd, >> >> On Thursday 30 March 2017 07:20 PM, Arnd Bergmann wrote: >>> On Thu, Mar 30, 2017 at 3:16 PM, Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> wrote: >>>> >>>> +config EXYNOS_CHIPID >>>> + bool "Exynos Chipid controller driver" if COMPILE_TEST >>>> + depends on ARCH_EXYNOS || COMPILE_TEST >>>> + select SOC_BUS >>> >>> This lets you disable the driver when COMPILE_TEST is set on exynos, >>> which is probably not what you wanted. >>> >> >> Sorry I could not get this point. EXYNOS_CHIPID is invisible menu >> option, when I enabled COMPILE_TEST, option is visible in make >> menuconfig but it does not allow to disable this driver. I have adopted >> this config same as EXYNOS_PMU in the same file. > > I wrote my comment before I saw the 'select' statement in the later > patch. With that select, it is not a problem. > >>> bool "Exynos Chipid controller driver" if COMPILE_TEST && !ARCHEXYNOS >>> default ARCH_EXYNOS >> >> I can adopt, default ARCH_EXYNOS, which will allow me to drop patch 5/12 >> and 6/12. > > Either way (select or default) is fine, just do the same thing for both chipid > and pmu. If you keep the 'select' and the 'if COMPILE_TEST', you can > drop the line 'depends on ARCH_EXYNOS || COMPILE_TEST'. > OK, I understood your point. Thanks. Pankaj Dubey > Arnd > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |