On 31/03/17 22:46, Russell King - ARM Linux wrote: > On Fri, Mar 31, 2017 at 02:20:27PM +0200, Hans Verkuil wrote: >> +struct cec_notifier *cec_notifier_get(struct device *dev) >> +{ >> + struct cec_notifier *n; >> + >> + mutex_lock(&cec_notifiers_lock); >> + list_for_each_entry(n, &cec_notifiers, head) { >> + if (n->dev == dev) { >> + mutex_unlock(&cec_notifiers_lock); >> + kref_get(&n->kref); > > Isn't this racy? What stops one thread trying to get the notifier > while another thread puts the notifier? > Both get and put take the global cec_notifiers_lock mutex. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html