On Thu, Feb 16, 2017 at 2:27 PM, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > If we request a GPIO hog, then gpiochip_add_data will attempt to request > some of its own GPIOs. The driver also uses gpiochip_generic_request > which means that for any GPIO request to succeed the pinctrl needs to be > registered. Currently however the driver registers the GPIO and then the > pinctrl meaning all GPIO hog requests will fail, which then in turn causes > the whole driver to fail probe. Fix this up by ensuring we register the > pinctrl first. Although currently there are no users of GPIO hogs in > mainline there are plenty of Samsung based boards that are widely used > for development purposes of other hardware. Indeed we hit this issue > whilst attaching some additional hardware to an Arndale system. > > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > --- > > Changes since v1: > - Updated commit message Patch applied. Will not be visible in -next until after the merge window though. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html