Re: [PATCH] ARM: dts: Add trackpad to exynos5250-snow-rev5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2017 at 04:11:17PM -0300, Javier Martinez Canillas wrote:
> > (although having many trackpads looks weird). You think this is only
> > for specific revisions of Snows?
> >
> 
> Yes, all Chromebooks have only one trackpad and it varies between revisions.
> 
> The reason the downstream ChromiumOS tree have both I2C devices in the same
> I2C bus was to have a common DTSI file to be used for all Exynos5250 boards.
> 
> This is the downstream commit in the ChromiumOS tree that added both devices
> to the common DTSI file and you can see the intention in the commit [0]:
> 
> "Since we'd now like both defined for exynos5250-snow, move the definition
> up to the cros5250-common device tree file.  This allows snow to work with
> _either_ the cyapa or atmel touch pad dynamically."
> 
> So in the downstream tree both cyapa and atmel_mxt_ts drivers are probed and
> only one succeeds. Obviously that's not the correct approach for doing this.

Indeed, this does not look right. Also meaningless probing of invalid I2C
devices usually takes some time... The trackpad should be added to
DTS for given revision of Snow.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux