On Sun, Feb 19, 2017 at 08:11:26PM +0100, Leandro Santiago wrote: > Thank you for the tips. I have just added linux-samsung-soc@xxxxxxxxxxxxxxx > to cc, even though get_mantainer.pl did not suggested such mailing list. The scripts suggests it: linux-samsung-soc@xxxxxxxxxxxxxxx (moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES) It also suggests other mailing lists... Maybe you are not using mainline kernel but in that case patch needs testing on mainline by someone else. Please send a proper v2 patch (git format-patch -v2) with proper title (I do not see any change below). I do not see also any change in the node order. Please address all of the comments. If you do not agree with some of them we can discuss but ignoring a comment is a no-go. > About the interrupts property, on the original chromeos-3.8, it was defined > as <2 0>, I just replaced the second zero by it by IRQ_TYPE_NONE as it > evaluates to zero anyways and is compatible with the existing trackpad > node. I have fixed it by setting it to IRQ_TYPE_EDGE_FALLING as you > suggested. I have no access to the platform data though, so could not check > if it's really correct or not. But still works fine on my chromebook. The platform data is in Linux kernel: http://lxr.free-electrons.com/source/drivers/platform/chrome/chromeos_laptop.c#L116 Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |