On Mon, Feb 13, 2017 at 10:11:06AM +0000, Charles Keepax wrote: > Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> "The local variable drvdata is not used in samsung_gpio_set_direction()"? Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index f291cbf..eb08f30 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -566,13 +566,11 @@ static int samsung_gpio_set_direction(struct gpio_chip *gc, > { > const struct samsung_pin_bank_type *type; > struct samsung_pin_bank *bank; > - struct samsung_pinctrl_drv_data *drvdata; > void __iomem *reg; > u32 data, mask, shift; > > bank = gpiochip_get_data(gc); > type = bank->type; > - drvdata = bank->drvdata; > > reg = bank->pctl_base + bank->pctl_offset > + type->reg_offset[PINCFG_TYPE_FUNC]; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html