On Tue, Feb 07, 2017 at 11:28:30PM +0200, Krzysztof Kozlowski wrote:
(...)
> > + /*
> > + * When reaching cpu0_alert4, reduce CPU
> > + * further, down to 600 MHz (12 steps for big,
> > + * 7 steps for LITTLE).
> > + */
> > + map5 {
> > + trip = <&cpu0_alert4>;
> > + cooling-device = <&cpu0 3 7>;
> > + };
> > + map6 {
> > + trip = <&cpu0_alert4>;
> > + cooling-device = <&cpu4 3 12>;
> > + };
>
> That is a quite big code duplication with a lot of possible errors to do
> (differs only by cpu number). We should do this in a smarter way.
>
> How about extending the thermal driver for setting the trips also for
> other thermal zones?
>
> > + };
> > + };
> > + cpu1_thermal: cpu1-thermal {
> > + thermal-sensors = <&tmu_cpu1 0>;
I confirmed your findings (taskset -c 5 dd if=/dev/zero of=/dev/null)
however thermal zones indices do not match CPU.
busy CPU | the most rising temp | TMU zone for this diff
=====================================================================
CPU4 (first A15) | 52 | thermal_zone0
CPU5 | 70 | thermal_zone3
CPU6 | 74 | thermal_zone2
CPU7 | 66 | thermal_zone1
CPU5-CPU7 | 97 | thermal_zone3 (but 2 similar)
The sensors are not showing the same temperature - neither in idle nor
in busy cycle. Maybe they are not properly calibrated or located in
symmetric location?
However the difference between idle and busy states is more or less
similar between thermal zones - making one A15 busy heats:
1. associated thermal zone by 21-26 degrees of C,
2. other thermal zones by 13-18 degrees (zone 3 is weird here).
Thermal zone 4 is probably GPU.
Anyway the bindings for thermal zones are not nice in this case and they
require huge duplication of data... Maybe this could be done smarter
way...
Full data:
https://docs.google.com/spreadsheets/d/1XOpRCK0YjnxaZgjLcasRdKXaFFVh3EqyvrDi_YcmBGE/edit?usp=sharing
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
