On Thu, Jan 19, 2017 at 2:48 PM, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > PMU is something like a SoC wide service, so add a helper function to get > PMU regmap. This will be used by other Exynos device drivers. This way it > can be avoided to model this dependency in device tree (as phandles to PMU > node) for almost every device in the SoC. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Reviewed-by: Tomasz Figa <tomasz.figa@xxxxxxxxx> But why? I could understand it as a local header in drivers/soc/samsung/*.h for those files. For the global kernel scope we usually look up the syscon regmap we need using a phandle, DT node or even compatible string directly from the device tree. Just #include <linux/mfd/syscon.h> syscon_node_to_regmap() syscon_regmap_lookup_by_compatible() syscon_regmap_lookup_by_pdevname() syscon_regmap_lookup_by_phandle() what is wrong with just using one of these? Introducing a special header just creates compile time problems with global interfaces when merging code and just litter the kernel for no good reason. Can you explain why this necessarily different approach is needed? I guess I should have said this earlier, mea culpa. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |