On Tue, Jan 24, 2017 at 02:57:00PM -0300, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 01/24/2017 02:52 PM, Krzysztof Kozlowski wrote:
> > On Tue, Jan 24, 2017 at 01:45:28PM +0100, Andrzej Hajda wrote:
> >> LDO7 regulator beside DSI and HDMI provides power for core blocks in Exynos
> >> 5433 SoC. Disabling it causes serious current leak - about 200mA.
> >>
> >> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> >> ---
> >> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> index 5f1e172..b22bec8 100644
> >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> >> @@ -432,6 +432,10 @@
> >> regulator-name = "VDD18_MIPI2L_1.8V_AP";
> >> regulator-min-microvolt = <1800000>;
> >> regulator-max-microvolt = <1800000>;
>
> I see you already applied, but I think it would be good to have some comments
> here explaining why the regulator should be always-on. Otherwise, in future a
> developer might want to disable the regulator since it may think that is not
> needed due dsi and hdmi already enabling it.
It is a good idea however we never put such information for other
regulators... If agreed, we might make it a requirement for new DTS and
new changes.
Anyway one could get this from the log itself.
>
> >> + regulator-always-on;
> >> + regulator-state-mem {
> >> + regulator-off-in-suspend;
> >> + };
> >
> > Thanks, applied.
> >
> > Just to satisfy my curiosity, how disabling the regulator causes current
> > leak? What happens exactly?
> >
>
> I was wondering the same.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
