Re: [PATCH] drm/exynos: fix a timeout loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




2017년 01월 23일 18:41에 Chris Wilson 이(가) 쓴 글:
> On Mon, Jan 23, 2017 at 06:32:16PM +0900, Inki Dae wrote:
>>
>>
>> 2017년 01월 21일 01:54에 Tobias Jakobi 이(가) 쓴 글:
>>> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>>
>>> We were trying to print an error message if we timed out here, but the
>>> loop actually ends with "tries" set to UINT_MAX and not zero.  Fix this
>>> by changing from tries-- to --tries.
>>
>> Sorry but I already know this patch from long ago but I'm not clear yet.
>> How the variable, tries, could have UNIT_MAX?
> 
> The value of tries after the final loop is -1u. The WARN fires on a
> succesful read on the final loop, instead of the complete failure.

Ah, right. thanks.

> -Chris
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux