Hello Marek, On 01/20/2017 05:37 AM, Marek Szyprowski wrote: [snip] >> I'll post a proper patch for the exynos5800.dtsi, to override the >> clocks in the gsc_pd device node. >> >> I also see that the two power domains that fail to be disabled msc_pd >> (power-domain@10044120) and isp_pd (power-domain@10044020) don't have >> clocks defined in the exynos54xx.dtsi. I'll add clocks for those too. > > Please send this patch instead of adding more clocks to the power domains. > This way we will avoid adding more dependencies to userspace (DT ABI). > Likely those clocks are also needed to access any device in that power > domains. > > Later, once the runtime PM for clocks get merged, a patch for exynos542x > clocks driver can be made to replace IS_CRITICAL with proper runtime > handling. > Ok, I thought that we didn't want to mark more clocks as CLK_IGNORE_UNUSED or CLK_IS_CRITICAL but I agree this can be done as a temporary workaround until a proper runtime PM based solution gets merged. > Best regards Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |