On 01/10/2017 05:32 PM, Javier Martinez Canillas wrote: > Hello Shuah, > > On 01/10/2017 09:30 PM, Shuah Khan wrote: > > [snip] > >>>> clk_disable_unprepare(exynos->axius_clk); >>>> +axius_clk_err: >>> >>> This label isn't consistent with the others, I know the errN aren't great >>> so what about changing those to meaningful names in a preparatory patch? >>> >>> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >>> >>> Best regards, >>> >> >> Javier, >> >> Right they aren't consistent. Changing them all to a better naming scheme >> will have be done in another cleanup patch in my opinion. I don't want to >> include cleanup in this fix. >> > > I didn't mean to be done in the same patch, that's why I said in another > preparatory patch. Yes. I can send the cleanup patch. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |