Re: [PATCH v2] ARM: dts: exynos: remove Exynos4212 support (dead code)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marek,

On 01/10/2017 04:48 AM, Marek Szyprowski wrote:
> Hi Javier,
> 
> On 2017-01-09 17:59, Javier Martinez Canillas wrote:
>> Hello Marek,
>>
>> On 01/09/2017 05:34 AM, Marek Szyprowski wrote:
>>> There are no Exynos4212 based boards in mainline, so there is no need to
>>> keep additional files for SoCs, which are never used. This patch removes
>>> support for Exynos4212 SoCs and moves previously shared Exynos4412
>>> definitions to a single file to simplify future maintenance.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>>> ---
>> Patch looks good to me.
>>
>> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>>
>> There are still a lot of references to Exynos4212 after this patch though.
>> I see Kconfig symbols, macros, SoC specific logic and compatibles strings
>> in Exynos platform code, drivers and DT bindings.
>>
>> Are you planning to also remove these as a follow-up?
> 
> Yes, I plan to send follow-ups, especially for clocks, pincontrol drivers and
> Kconfigs. However I don't plan to change compatible strings to keep
> so called compatibility with old dtbs as requested by Krzysztof some time ago.
> Drivers for Exynos4412 hw modules will still use "exynos4x12", "exynos4212"
> and "exynos4412" strings as they do now.
>

I see, that makes sense. Thanks for the explanation.
 
> Best regards

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux