On Sat, Dec 17, 2016 at 09:36:59AM +0530, Pankaj Dubey wrote: > Hi Krzysztof, > > On 16 December 2016 at 23:07, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Sat, Dec 10, 2016 at 06:38:36PM +0530, Pankaj Dubey wrote: > >> Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. > >> This patch intends to provide initialization code for all these functionalities, > >> at the same time it provides some sysfs entries for accessing these information > >> to user-space. > >> > >> This driver uses existing binding for exynos-chipid. > >> > >> CC: Grant Likely <grant.likely@xxxxxxxxxx> > >> CC: Rob Herring <robh+dt@xxxxxxxxxx> > >> CC: Linus Walleij <linus.walleij@xxxxxxxxxx> > >> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > >> [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] > >> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > >> --- > >> drivers/soc/samsung/Kconfig | 5 ++ > >> drivers/soc/samsung/Makefile | 1 + > >> drivers/soc/samsung/exynos-chipid.c | 116 ++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 122 insertions(+) > >> create mode 100644 drivers/soc/samsung/exynos-chipid.c > >> > >> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > >> index 2455339..f9ab858 100644 > >> --- a/drivers/soc/samsung/Kconfig > >> +++ b/drivers/soc/samsung/Kconfig > >> @@ -14,4 +14,9 @@ config EXYNOS_PM_DOMAINS > >> bool "Exynos PM domains" if COMPILE_TEST > >> depends on PM_GENERIC_DOMAINS || COMPILE_TEST > >> > >> +config EXYNOS_CHIPID > >> + bool "Exynos Chipid controller driver" if COMPILE_TEST > >> + depends on (ARM && ARCH_EXYNOS) || ((ARM || ARM64) && COMPILE_TEST) > > > > 1. Why this can be compile tested only on ARM architectures? > > Well I just used dependency same as EXYNOS_PMU, but I can see it will > be enabled for compile test on ARM64 isn't it? I don't remember the PMU case... maybe it used clocks or something. Here there are no arch-specific build dependencies. > > > 2. Don't you need also SOC_BUS? > > CHIPID needs SoC_BUS and for the same reason it is selecting SOC_BUS > in the next line. > If we mark it as a dependency (under depends on), even then we need to > select this either > under same EXYNOS_CHIPID config or ARCH_EXYNOS config. Ah, I missed that line... Argh, sorry for noise. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |