Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote: > This patch add regmap initialization to use register map > in max8997-clk device driver > > CC: Lee Jones <lee.jones@xxxxxxxxxx> > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> > --- Patch looks good to me. Now that the driver uses regmap, I think you should be able to get rid of drivers/mfd/max8997-irq.c and use the regmap IRQ chip like is done in most Maxim PMIC MFD drivers. That can be done as a follow-up of this series though. Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html