On 10/26/2016 11:21 AM, Arnd Bergmann wrote:
> On Wednesday, October 26, 2016 11:08:27 AM CEST Sylwester Nawrocki wrote:
>> > @@ -1685,13 +1684,7 @@ static int s3cmci_probe(struct platform_device *pdev)
>> > /* depending on the dma state, get a dma channel to use. */
>> >
>> > if (s3cmci_host_usedma(host)) {
>> > - dma_cap_mask_t mask;
>> > -
>> > - dma_cap_zero(mask);
>> > - dma_cap_set(DMA_SLAVE, mask);
>> > -
>> > - host->dma = dma_request_slave_channel_compat(mask,
>> > - s3c24xx_dma_filter, (void *)DMACH_SDI, &pdev->dev, "rx-tx");
>> > + host->dma = dma_request_slave_channel(&pdev->dev, "rx-tx");
>> > if (!host->dma) {
>> > dev_err(&pdev->dev, "cannot get DMA channel.\n");
>> > ret = -EBUSY;
>
> Can you convert it to use dma_request_chan()+PTR_ERR_OR_ZERO() instead?
Thanks for your review. dma_request_chan() seems to be returning
either valid pointer or ERR_PTR(), so it would be sufficient
to use just PTR_ERR(host->dma) on error path?
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
