On 10/19/2016 10:23 AM, Tobias Jakobi wrote: > Hello Shuah, > > just a short note that more misleading comments about default allocation > flags can be found in libdrm. > > https://cgit.freedesktop.org/mesa/drm/tree/exynos/exynos_drm.c > > See e.g. the comment for exynos_bo_create(). > > In my opinion, the whole approach to _set_ a bit to get non-contigious > memory is messed up. It would make more sense to me to set a bit to > request an additional property (here "being contiguous") of the memory. > > Anyway, clearing up this situation is highly appreciated! > > More comments below. > > With best wishes, > Tobias > Hi Tobias, Thanks for the note. Yes the comments are confusing. It seems like some old assumptions are persisting. I will fix these as well. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |