I have one comment though, if you're anyway making changes to all the DTS files: On Thu, Sep 1, 2016 at 9:23 AM, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > - samsung,pin-function = <2>; > - samsung,pin-pud = <0>; > - samsung,pin-drv = <0>; > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>; Nowadays we have standard bindings for this, see Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Section "Generic pin multiplexing node content". By patching the driver and bindings to accept also the standard bindings with just function and pins and also adding support for standard pin configurations like bias-disable bias-pull-up with the old samsung,* bindings as a fallback etc you can actually modernize the whole binding and DTS looks to something simpler. You will find that this is how newer platforms do it. But it is admittedly a bigger project. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |