On 08/16/2016 08:49 AM, perr perr wrote: > Because chained_irq_enter() has already called chip->irq_mask() and > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > so it's not necessary to call chip->irq_*() here. > > Signed-off-by: Perr Zhang<strongbox8@xxxxxxxx> > > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Hi, Thanks for fixing Signed-off-by but now the commiter name does not match Signed-off-by. In the same time you skipped the tags you got already (Tomasz's ack and my reviewed-by). BR, Krzysztof > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c > index 051b5bf..d32fa2b 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) > int eint_irq; > > chained_irq_enter(chip, desc); > - chip->irq_mask(&desc->irq_data); > - > - if (chip->irq_ack) > - chip->irq_ack(&desc->irq_data); > > eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); > generic_handle_irq(eint_irq); > - chip->irq_unmask(&desc->irq_data); > + > chained_irq_exit(chip, desc); > } > > -- > 1.9.3 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |