Re: [PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/08/2016 10:56 AM, Krzysztof Kozlowski wrote:
> On Fri, Aug 05, 2016 at 07:50:06PM -0600, Shuah Khan wrote:
>> Fix unsupported GEM memory type error message to include the memory type
>> information.
>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
>> index e016640..c9315df 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
>> @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev,
>>  	flags = exynos_gem->flags;
>>  
>>  	/*
>> -	 * without iommu support, not support physically non-continuous memory
>> +	 * without iommu support, not support physically non-contiguous memory
> 
> While at it, how about changing entire sentence to something in English? :)

Yes I can do that. Will send v2 :)

> 
> Best regards,
> Krzysztof
> 
>>  	 * for framebuffer.
>>  	 */
>>  	if (IS_NONCONTIG_BUFFER(flags)) {
>> -		DRM_ERROR("cannot use this gem memory type for fb.\n");
>> +		DRM_ERROR("Non-continguous GEM memory is not supported.\n");
>>  		return -EINVAL;
>>  	}
>>  
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux