Hi, just a question, > > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); > > - if (IS_ERR(pdev)) > > - return PTR_ERR(pdev); > > + if (!pdev) > > + return -ENOMEM; > > > > /* > > * use the first registered sysmmu device for performing > > > is ENOMEM the right return value? of_platform_device_create() doesn't fail only in case of malloc failure. Shouldn't it be ENODEV instead, which might also mean with some imagination that there is no memory available for that device? Thanks, Andi > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html