The Kconfig currently controlling compilation of this code is: event/Kconfig:config DEVFREQ_EVENT_EXYNOS_NOCP event/Kconfig: bool "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> Cc: Kukjin Kim <kgene@xxxxxxxxxx> Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Cc: linux-pm@xxxxxxxxxxxxxxx Cc: linux-samsung-soc@xxxxxxxxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- drivers/devfreq/event/exynos-nocp.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index 6b6a5f310486..f954578abfdf 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -10,7 +10,7 @@ */ #include <linux/clk.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/devfreq-event.h> #include <linux/kernel.h> #include <linux/of_address.h> @@ -280,25 +280,12 @@ static int exynos_nocp_probe(struct platform_device *pdev) return 0; } -static int exynos_nocp_remove(struct platform_device *pdev) -{ - struct exynos_nocp *nocp = platform_get_drvdata(pdev); - - clk_disable_unprepare(nocp->clk); - - return 0; -} - static struct platform_driver exynos_nocp_driver = { .probe = exynos_nocp_probe, - .remove = exynos_nocp_remove, .driver = { .name = "exynos-nocp", + .suppress_bind_attrs = true, .of_match_table = exynos_nocp_id_match, }, }; -module_platform_driver(exynos_nocp_driver); - -MODULE_DESCRIPTION("Exynos NoC (Network on Chip) Probe driver"); -MODULE_AUTHOR("Chanwoo Choi <cw00.choi@xxxxxxxxxxx>"); -MODULE_LICENSE("GPL"); +builtin_platform_driver(exynos_nocp_driver); -- 2.8.4 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html