Hi Bart, 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>: > Add the CPU clocks configuration data and instantiate the CPU clocks > type for Exynos5433. > > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > --- > drivers/clk/samsung/clk-exynos5433.c | 72 ++++++++++++++++++++++++++++++++---- > 1 file changed, 64 insertions(+), 8 deletions(-) Please see my comments inline. > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 6dd81ed..9ff6160 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c [snip] > static void __init exynos5433_cmu_apollo_init(struct device_node *np) > @@ -3620,6 +3640,12 @@ static void __init exynos5433_cmu_apollo_init(struct device_node *np) > ARRAY_SIZE(apollo_div_clks)); > samsung_clk_register_gate(ctx, apollo_gate_clks, > ARRAY_SIZE(apollo_gate_clks)); > + > + exynos_register_cpu_clock(ctx, CLK_SCLK_APOLLO, "apolloclk", > + mout_apollo_p[0], mout_apollo_p[1], 0x200, > + exynos5433_apolloclk_d, ARRAY_SIZE(exynos5433_apolloclk_d), > + CLK_CPU_HAS_E5433_REGS_LAYOUT); Hmm, I guess the reason for patch 1/3 was that exynos_register_cpu_clock() has to be called with the ctx pointer. However samsung_cmu_register_one() returns the ctx pointer, so I guess you could use that to avoid open-coding? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |