On 06/13/2016 05:32 PM, Mark Brown wrote: > On Mon, Jun 13, 2016 at 12:52:38PM +0200, Sylwester Nawrocki wrote: > >> > + - maxim,rx-path : indicates speaker source interface: >> > + 0 - PCM monomix output, >> > + 1 - Analog input, >> > + 2 - left PDM channel (CH0), >> > + 3 - right PDM channel (CH1) > > This should be a DAPM control. > >> > + - maxim,rx-channel-mask : a bitmask indicating active PCM Rx channels, >> > + bits b7...b0 correspond to channels CH7...CH0 > > This should be done using the TDM API. I suspected these don't belong here. I'll add a DAPM control for speaker source and will learn about the TDM API. I'm inclined to simply omit the PCM Rx channels configuration feature for now, as the MAX98504's PCM interface is left unconnected on our board. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html