Hello Inki, On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae <inki.dae@xxxxxxxxxxx> wrote: [snip] >> I know that removing .trg_type is enough but I also removed those lines >> because the fields are not used if .trg_type != I80_HW_TRG. So there is >> no point to leave a set for unused fields. >> >> We can latter add those one HW trigger support is fixed for Exynos5420. >> > > As of now, I can merge it but I think it would be not reasonable solution because potential problem still exists even we use SW trigger mode in default - ie., in case of using HW trigger mode at bootloader, same problem would happen as long as we don't support PSR mode support. > Yes, I understand that the problem will show again if the bootloader uses HW trigger mode and that we need proper Panel Self Refresh support but I think that's a separate issue. That's why I said that those can be addressed for v4.8 but revert to SW trigger for v4.7 as a short term fix for the regression. In other words, enabling HW trigger mode breaks the display for the Exynos5420 and Exynos5800 Peach Pi Chromebooks with the shipped bootloaders (which are probably the most popular Exynos5 devices with display and mainline support so is likely to affect users). Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |