Hi Tomasz and Krzysztof, On 2016년 04월 13일 15:20, Tomasz Figa wrote: > 2016-04-12 14:25 GMT+03:00 Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>: >> On 04/08/2016 07:00 AM, Chanwoo Choi wrote: >>> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI >>> Bus. This clock should be handled in Bus frequency scaling driver. >>> >>> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >>> --- >>> drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++------------- >>> 1 file changed, 55 insertions(+), 30 deletions(-) >> >> The IDs itself look good but you are not adding only clock ID. You are >> changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should >> be explained in the commit message why you need it. Probably it should >> be also in separate commit. > > +1. And CLK_SET_RATE_PARENT for a clock which has a mux as its parent > is a bit suspicious, so I'd like to know the rationale for each single > clock with CLK_SET_RATE_PARENT being added. This patch don't need the CLK_SET_RATE_PARENT flag. As Tomasz's comment, the mux of divider's parent don't need this flag. Sorry for confusion. I'll drop the CLK_SET_RATE_PARENT flag. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |