Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote:
> The driver's init and exit function don't do anything besides registering
> and unregistering the platform driver, so the module_platform_driver()
> macro could just be used instead of having separate functions.
> 
> Currently the macro is not being used because the driver is initialized at
> subsys init call level but this isn't necessary since consumer devices are
> defined in the DT as dependencies so there's no need for init calls order.
> 
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> 
> ---
> This patch was tested on an Exynos5422 Odroid XU4 board.

This test might not be sufficient. XU4 is not a mobile device like many
other users of this driver (except Arndale Octa and Artiks all of other
users are mobiles/wearables).

For example XU4 does not have USB OTG (like other devices and like XU3).

Best regards,
Krzysztof

> 
>  drivers/regulator/s2mps11.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux