Hi, On Thu, Mar 31, 2016 at 2:56 AM, Thierry Reding <treding@xxxxxxxxxx> wrote: > Ugh... most of these functions shouldn't be there in the first place. We > have helpers in the core that already do this. Most of the functionality > is duplicated in this driver. > > I realize that this is a problem that existed in the Exynos DP driver, > but somebody really ought to rewrite those parts to make use of the DRM > DP helpers. As I understand it from discussions in <http://article.gmane.org/gmane.linux.drivers.devicetree/162059> and <http://article.gmane.org/gmane.linux.kernel.samsung-soc/53048>, we shouldn't block merging the series but someone should pick up this work after the merge. So probably Yakir should fixup the problem pointed out by Guenter and send a new pull. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html