W dniu 11.03.2016 o 16:49, Krzysztof Kozlowski pisze:
> Driver enabled runtime PM but did not revert this on removal. Re-binding
> of a device triggered warning:
> exynos-rng 10830400.rng: Unbalanced pm_runtime_enable!
>
> Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number generator")
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/char/hw_random/exynos-rng.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
> index 68c349bf66a0..cba1ff538c46 100644
> --- a/drivers/char/hw_random/exynos-rng.c
> +++ b/drivers/char/hw_random/exynos-rng.c
> @@ -154,6 +154,13 @@ static int exynos_rng_probe(struct platform_device *pdev)
> return ret;
> }
>
> +static int exynos_rng_remove(struct platform_device *pdev)
> +{
> + pm_runtime_disable(&pdev->dev);
> +
This is not sufficient. pm_runtime_dont_use_autosuspend() is also
necessary here. I will send a v2.
BTW, no problem if it is too late for taking this for v4.6. If this
patchset misses merge window I'll resend it later.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
