Hello Sylwester, On Fri, Mar 11, 2016 at 10:09 AM, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: >> Thanks, I just noticed another similar issue in the driver now and is >> that fimc_is_parse_sensor_config() uses the same struct device_node * >> for looking up the I2C sensor, port and endpoint and thus not doing a >> of_node_put() for all the nodes on the error path. >> >> I think the right fix is to have a separate struct device_node * for >> each so their reference counter can be incremented and decremented. > > Yes, the node reference count is indeed not handled very well there, > feel free to submit a patch to fix that bug. > Ok, I'll post a patch to fix that once all the in-flight patches land to avoid merge conflicts. > -- > Regards, > Sylwester Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |