On 07.03.2016 10:01, Vladimir Zapolskiy wrote: > Hi Krzysztof, > > On 06.03.2016 12:17, Krzysztof Kozlowski wrote: >> Remove unneeded inclusion of delay.h and get rid of indentation from >> labels. > > just in case are you aware of this discussion regarding goto labels > http://lkml.iu.edu/hypermail/linux/kernel/0706.0/0809.html ? > > Practically there is no big need (neither it is a clean-up IMHO) > to change column 1 indentation of goto labels, however I do agree that > ^[a-z0-9_]\+:$ style of goto labels is 10 times more commonly used, > and that means it's a good time to update my ~/.emacs config. > > Someone may want to fix the style of another 5000+ goto labels one day, > though it is better to have an officially agreed policy beforehand. > > Anyway I do not strictly object against the change, see one my comment > below and feel free to add my > > Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx> Actually I was not aware of that discussion, thanks for pointing this out. Mostly I encountered the style without indentation but of course that does not mean it is the only one. > >> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> >> --- >> drivers/crypto/s5p-sss.c | 15 +++++++-------- >> 1 file changed, 7 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c >> index 5f161a9777e3..60f835455a41 100644 >> --- a/drivers/crypto/s5p-sss.c >> +++ b/drivers/crypto/s5p-sss.c >> @@ -11,7 +11,6 @@ >> * >> */ >> >> -#include <linux/delay.h> >> #include <linux/err.h> >> #include <linux/module.h> >> #include <linux/init.h> > > Since you are here, can you sort headers out, please? You mean sort by name (or by christmas tree)? I can... I am not sure about benefits of such patch (which should be the motivation for change). > And I'm pretty sure some more inclusions can be safely removed > from the list. I checked them while removing delay - all of them seem to be used. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |