On 25.02.2016 13:19, pankaj.dubey wrote: > Hi Krzysztof, > >>> >>> OMAP has GPMC drivers under drivers/memory. I wonder if SROM should go there >>> too, since it's a quite similar bus. >> >> I wish I get this feedback before, when we were discussing the SROM >> patches. :/ >> >> Indeed this sounds reasonable. On some boards the omap-gpmc is used for >> the same purpose: interfacing to smsc,lan9115 (like on SMDK5410). >> >> >>> Feel free to respin this without SROM now, so we can get the other pieces in >>> sooner and then revisit the SROM asyncronously. That'll remove the dependencies >>> on DT as well. >> >> Okay, I'll rebase all drivers/soc branches and respin the pull request >> so PMU driver and other stuff could go in. >> >> BTW, just in case, although PMU stands for "Power Management Unit" I >> don't think it should be placed under drivers/power because it is not a >> avs/charger/battery/reset driver. Existing power-related drivers are >> under driver/soc (bcm, dove, tegra). >> >> Re-work of SROM drivers could be started on top of it. >> > > Please let me know if I need to take care of any of this work. Yes, unfortunately I need your help with that. I rebased mach-exynos/drivers-soc related patches and pushed it to my next/soc branch: https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/soc There are some changes in commits, mostly for movement of PMU driver (now it is applied first, before SROMc driver). I also applied some of the cleanup and maintainer patches from SROMc patchset. DT changes are already merged. Overall, could you rebase remaining patches on top of my next/soc and move SROM driver to drivers/memory? You can also rebase Pavel Fedin's patches (if you don't I will rebase them). Last version of applied SROMc patches is here: https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=for-v4.6/drivers-soc-exynos-srom-pmu Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html